Tower of Frozen Shadow - some questions.

[Schnuller]

http://thedruidsgrove.org/archive/eq/t-3884.html

according to the post from Scirocco "07-02-2001, 10:53 AM" the room had 6 mirrors.

hope this helps.

Slothbynature Lazybutt

[fadetree]

Well, I was actually just teasing, but if you are seriously asking, its bad programming style. If you ever need to change the way something is defined that you've hardcoded, (in this case its an item id), you'll have to go hunt through all the source for occurrences and make sure you get them all. If they are centrally defined somewhere you can just change that one spot.

$oncursor(20039)

becomes something like

$oncursor(LEFT_PORTAL_KEY)

Makes it easier to read as well. You'd have the constant LEFT_PORTAL_KEY defined as being equal to 20039 in some constants file that all of the code imports from.

Now, I don't know if in the specific case of EQ EMU scripting it is important or not ( ie., there is NO chance the ID numbers would ever change and you have them all memorized ), but it's still considered generally bad coding practice.

[Danyelle]

Originally Posted by fadetree [You must be logged in to view images. Log in or Register.]

Well, I was actually just teasing, but if you are seriously asking, its bad programming style. If you ever need to change the way something is defined that you've hardcoded, (in this case its an item id), you'll have to go hunt through all the source for occurrences and make sure you get them all. If they are centrally defined somewhere you can just change that one spot.

$oncursor(20039)

becomes something like

$oncursor(LEFT_PORTAL_KEY)

Makes it easier to read as well. You'd have the constant LEFT_PORTAL_KEY defined as being equal to 20039 in some constants file that all of the code imports from.

Now, I don't know if in the specific case of EQ EMU scripting it is important or not ( ie., there is NO chance the ID numbers would ever change and you have them all memorized ), but it's still considered generally bad coding practice.

What he posted is the player.pl perl script for TOFS. The items are only defined there. Not in the server code or other quest files. So doing that would actually be far more complicated in this case. Generally you're right, though in this case it's easier as he has it.

[Muergan]

I seem. To remember them porting you back outside, and only because I recall fighting to the top and two group members click wrong mirror and getting the boot to iceclad effectively ruining our attempt on tserrina.

[doraf]

Originally Posted by Danyelle [You must be logged in to view images. Log in or Register.]

What he posted is the player.pl perl script for TOFS. The items are only defined there. Not in the server code or other quest files. So doing that would actually be far more complicated in this case. Generally you're right, though in this case it's easier as he has it.

Thanks Danyelle. This is why I asked.

I wasn't trying to bust fadetree's balls or anything, just curious. [You must be logged in to view images. Log in or Register.]

[Nirgon]

Release Velious. Easy one.

Didn't read anything else in here.

[maximum]

I found this guide to ToFS, and it appears Classic Era. It lists the keyholders and mirrors.

http://eqrez.com/stormhaven/forums/v....php?f=12&t=22

"...[Tserrina] will drop a golden key that is the master key to the dungeon! Which will allow you to teleport straight to the top using the mirror on the left at the very beginning of the zone (instead of the one on the right that takes you to the library)"

[Aeolwind]

Originally Posted by maximum [You must be logged in to view images. Log in or Register.]

I found this guide to ToFS, and it appears Classic Era. It lists the keyholders and mirrors.

http://eqrez.com/stormhaven/forums/v....php?f=12&t=22

"...[Tserrina] will drop a golden key that is the master key to the dungeon! Which will allow you to teleport straight to the top using the mirror on the left at the very beginning of the zone (instead of the one on the right that takes you to the library)"

This is from the Storm Haven EQEmu server. And as such, is suspect.

[Rooj]

I never really got to explore TOFS. Can't wait [You must be logged in to view images. Log in or Register.]

[Kika Maslyaka]

Technically there ARE 8 floors, but they are 6A and 6B which do not require a key to go between them. But if one would add a key to the mirror on 6A - you would effectively have 8 floors and a function for the 8th mirror.
Perhaps that was the original Verant design, but then they decided that 6s were too small and grouped them into a single floor.