Spells: damage shields doing reduced damage in pvp

[Lasher]

I dont recall ds doing reduced dmg in pvp, it did on vztz. Unless there is proof showing live had ds pvp dmg reduced i think it would be ridiculous considering ds last aroud 5 mins so to add reduction to it would severly gimp the applications of it in pvp

[Nirgon]

It did full damage in pvp.

There will be much crying and disputing, but it was full.

[MC Epic]

Originally Posted by Nirgon [You must be logged in to view images. Log in or Register.]

It did full damage in pvp.

There will be much crying and disputing, but it was full.

Damage shields did full damage.

[Alecta]

In spdat.h:

bool IsDamageShieldSpell(uint16 spell_id);

In spdat.cpp:

///////////////////////////////////////////////////////////////////////////////
// spell property testing functions

bool IsDamageShieldSpell(uint16 spell_id)
{
	return IsEffectInSpell(spell_id, SE_DamageShield);
}

In attack.cpp (adapt as is necessary, as I am sure its customized):

	// cut all PVP spell damage to 2/3 -solar
	// EverHood - Blasting ourselfs is considered PvP 
	//Don't do PvP mitigation if the caster is damaging himself
	if(other && other->IsClient() && (other != this) && damage > 0 && !IsDamageShieldSpell(spell_id) ) {

[heartbrand]

Null is on it

[Nirgon]

Originally Posted by heartbrand [You must be logged in to view images. Log in or Register.]

Null is on it

Null's gone. Time to own the issue.

[Bamzal Sherbet]

confirmed DS's were a more serious issue on live

[Alecta]

Yeah, which is why I provided an implementation, which we're burying with each subsequent post.

[Ruprecht]

Originally Posted by Alecta [You must be logged in to view images. Log in or Register.]

Yeah, which is why I provided an implementation, which we're burying with each subsequent post.

Yeah, the devs haven't fixed it yet because all this time they were desperately awaiting that prophesied day when a random member of the community should arrive to bestow upon them a few lines of trivial code.

[You must be logged in to view images. Log in or Register.]

[Alecta]

Eh, was just going off http://www.project1999.org/forums/showthread.php?t=6897, which is why I bumped the year and a half old post with all the 'proof' with a code submission.

But if the preferred approach is to just QQ and snipe, I can roll with that too.