I made a P99 DPS calculator for melee classes based on EQEMU code

[loramin]

Originally Posted by DeathsSilkyMist [You must be logged in to view images. Log in or Register.]

In playground.io the console.log() function shows the array index and the value ...

The wiki version just shows the value:

...

If they were displayed in tables that would probably be easy to read as well.

Those three result fields are now displayed as tables, with a header row of the indices (I assumed you wanted them 1-based and not 0-based).

Again, it's not the most beautiful, so if you want to provide some styling I'll be happy to update ... but at least people can see the indices now.

[DeathsSilkyMist]

Originally Posted by loramin [You must be logged in to view images. Log in or Register.]

Those three result fields are now displayed as tables, with a header row of the indices (I assumed you wanted them 1-based and not 0-based).

Again, it's not the most beautiful, so if you want to provide some styling I'll be happy to update ... but at least people can see the indices now.

The tables are looking good! They are 0 based actually. 0 is misses. So one small fix there.

EDIT: Maybe name the 0 column "misses" so people know.

[loramin]

Originally Posted by DeathsSilkyMist [You must be logged in to view images. Log in or Register.]

The tables are looking good! They are 0 based actually. 0 is misses. So one small fix there.

EDIT: Maybe name the 0 column "misses" so people know.

Fixed.

[DeathsSilkyMist]

Originally Posted by loramin [You must be logged in to view images. Log in or Register.]

Fixed.

That's perfect. Thanks again Loramin!

[DeathsSilkyMist]

Originally Posted by loramin [You must be logged in to view images. Log in or Register.]

Fixed.

It looks like the wiki calculator doesn't allow users to adjust the textbox values. Bcbrown and myself are unable to edit things like AC and Defense. The calculator looks like it is only using the default values, it doesn't accept the new values. Some of the textboxes are working, like Off Hand Weapon Damage.

[loramin]

Originally Posted by DeathsSilkyMist [You must be logged in to view images. Log in or Register.]

It looks like the wiki calculator doesn't allow users to adjust the textbox values. Bcbrown and myself are unable to edit things like AC and Defense. The calculator looks like it is only using the default values, it doesn't accept the new values. Some of the textboxes are working, like Off Hand Weapon Damage.

I checked the code, and the problem I found was actually with the mob (not player) stats: they weren't using the form values.

However, I have no idea what values are correct (I don't play many melee characters), so I can't really do much more QA myself: that's all on you DSM.

(Developer Talk) If you want to debug the code further yourself, you can use the browser dev tools to do so. Open the dev tools (F12), go to the sources tab, and pick the file "index.php?title=MediaWiki: DamageCalculator.js&action=raw&ctype=text/javascript" (it should be the second "index.php?" one on the list). You can then see the source code, add break points, trigger the form, and check any variables' values.

For instance,if you add a break point to line 141:

const results = RunDPSTest(playerStats, mobStats, 500);

... and then hover over playerStats/mobStats, you can now see that they use the form's values.


(Non-Developer Talk) If anyone else wants to check it out, you'll have to clear your cache (or else you might have to wait a few days to see the changes). A simple way (for anyone, not just a developer) to do this in Chrome is to open the developer tools (F12), click and hold down the reload button, and then pick "Empty Cache and Hard Reload" (and then do F12 to close the dev tools after).

[DeathsSilkyMist]

Originally Posted by loramin [You must be logged in to view images. Log in or Register.]

I checked the code, and the problem I found was actually with the mob (not player) stats: they weren't using the form values.

Thanks again for the fix! Did some super quick testing and it looks like all the fields are working now.