I made a P99 DPS calculator for melee classes based on EQEMU code

[loramin]

I took the liberty of "wikifying" your calculator: https://wiki.project1999.com/Damage_Calculator. It's still quite rough, but it lets people see your work (and I got the sense that you weren't completely finished, so I didn't want to waste a lot of time on polish).

You can see the wiki code at https://wiki.project1999.com/MediaWi...eCalculator.js. As you can see there, I tried to leave your code as is, and just wrap it with form code (so it'd be easy to update with any new versions you make). However, I did have to modify your main function (RunDPSTest), to make it return an object containing the results, rather than logging them to the console (so I could display them).

P.S. It's also untested, so I make no promises about it being bug free [You must be logged in to view images. Log in or Register.]

[DeathsSilkyMist]

Originally Posted by loramin [You must be logged in to view images. Log in or Register.]

I took the liberty of "wikifying" your calculator: https://wiki.project1999.com/Damage_Calculator. It's still quite rough, but it lets people see your work (and I got the sense that you weren't completely finished, so I didn't want to waste a lot of time on polish).

You can see the wiki code at https://wiki.project1999.com/MediaWi...eCalculator.js. As you can see there, I tried to leave your code as is, and just wrap it with form code (so it'd be easy to update with any new versions you make). However, I did have to modify your main function (RunDPSTest), to make it return an object containing the results, rather than logging them to the console (so I could display them).

P.S. It's also untested, so I make no promises about it being bug free [You must be logged in to view images. Log in or Register.]

Thanks a bunch for this Loramin! I'll see if I can polish it up a bit. I can modify this right? This is an awesome starting point. I don't have a ton of knowledge on how to do this sort of thing on the wiki, and a working example is the best way to learn.

Originally Posted by Snaggles [You must be logged in to view images. Log in or Register.]

Sorry DSM. I thought this was in the other thread.

Kudos for making something folks can use [You must be logged in to view images. Log in or Register.]

No worries!

[loramin]

Originally Posted by DeathsSilkyMist [You must be logged in to view images. Log in or Register.]

I can modify this right?

Unfortunately only wiki admins can edit the Javascript, but if you want to send me a new version I'd be happy to update the wiki with it.

[DeathsSilkyMist]

Originally Posted by loramin [You must be logged in to view images. Log in or Register.]

Unfortunately only wiki admins can edit the Javascript, but if you want to send me a new version I'd be happy to update the wiki with it.

Great! I'd say the main thing that needs improving at the moment is the display of the output arrays.

In playground.io the console.log() function shows the array index and the value. For example:

Index 0: 100,
Index 1: 22,
Index 2: 1,
...

The wiki version just shows the value:

100,
22,
1,
...

The wiki calculator should show the array index and value. For the damage arrays, the index is the damage number, and the value is the number of times the damage number was rolled. For the roll array, the index is the dice roll and the value is the number of times it was rolled.

The array variables I am referring to are:

uniqueMainHandDamageValueCountArray
uniqueOffHandDamageValueCountArray
uniquediceRollCountArray

If they were displayed in tables that would probably be easy to read as well.

[loramin]

Originally Posted by DeathsSilkyMist [You must be logged in to view images. Log in or Register.]

In playground.io the console.log() function shows the array index and the value ...

The wiki version just shows the value:

...

If they were displayed in tables that would probably be easy to read as well.

Those three result fields are now displayed as tables, with a header row of the indices (I assumed you wanted them 1-based and not 0-based).

Again, it's not the most beautiful, so if you want to provide some styling I'll be happy to update ... but at least people can see the indices now.

[DeathsSilkyMist]

Originally Posted by loramin [You must be logged in to view images. Log in or Register.]

Those three result fields are now displayed as tables, with a header row of the indices (I assumed you wanted them 1-based and not 0-based).

Again, it's not the most beautiful, so if you want to provide some styling I'll be happy to update ... but at least people can see the indices now.

The tables are looking good! They are 0 based actually. 0 is misses. So one small fix there.

EDIT: Maybe name the 0 column "misses" so people know.

[loramin]

Originally Posted by DeathsSilkyMist [You must be logged in to view images. Log in or Register.]

The tables are looking good! They are 0 based actually. 0 is misses. So one small fix there.

EDIT: Maybe name the 0 column "misses" so people know.

Fixed.