Moss covered Twig

[DeathsSilkyMist]

Originally Posted by Goregasmic [You must be logged in to view images. Log in or Register.]

Twig as a secondary weapon has a 0.3 ratio and is fucking terrible by any metric at this point, assumed OP asked about its original form.

But considering he's comparing it to velious weaps, yeah, makes no sense.

It has an even worse ratio because offhand swings are triggered by primary hand swings. This means you get no benefit from having an offhand weapon that is faster than your primary weapon.

At best Twig is a 3/15 weapon in your offhand if you have Mosscovered Branch in your main hand, which is the fastest primary hand weapon at 15 delay. So it's a 0.2 ratio weapon or worse.

[Zuranthium]

Originally Posted by DeathsSilkyMist [You must be logged in to view images. Log in or Register.]

offhand swings are triggered by primary hand swings. This means you get no benefit from having an offhand weapon that is faster than your primary weapon.

No, they are independent of each other. How are you making a DPS calculator and saying this shit.

[Goregasmic]

I thought for DW, off hand was 100% independent but it had to pass a DW check meaning it fired less often. The DW wiki page says you can get more OH hits than MH hits if OH is faster than MH.

You're not going to get more OH swings than your DW percentage because that's what lets you swIng OH...

[DeathsSilkyMist]

Originally Posted by Goregasmic [You must be logged in to view images. Log in or Register.]

I thought for DW, off hand was 100% independent but it had to pass a DW check meaning it fired less often. The DW wiki page says you can get more OH hits than MH hits if OH is faster than MH.

You're not going to get more OH swings than your DW percentage because that's what lets you swIng OH...

I'll double check the game and the EQEMU code again.

[bcbrown]

I'm saying the wiki version seems to correctly treat offhand delay. Did you really mess it up in the later version?

function computeWeaponDelayWithHaste(attackerStatStruct, bUseOffhand, bLogHasteValue)
{
	const mn_WeaponDelayDenominator = 100;

	var attackerWeaponDelay = attackerStatStruct.mainHandWeaponDelay;
	if(bUseOffhand)
	{
		attackerWeaponDelay = attackerStatStruct.offHandWeaponDelay;
	}
	...
}

function RunCombatSimulation(...)
{
	...
	const mainHandDelayHasteAdjustedInSeconds = (computeWeaponDelayWithHaste(attackerStatStruct, false, false) / 10);
	const offHandDelayHasteAdjustedInSeconds = (computeWeaponDelayWithHaste(attackerStatStruct, true, false) / 10);
	...
	const mainHandOffHandDelayRatio = (mainHandDelayHasteAdjustedInSeconds / offHandDelayHasteAdjustedInSeconds) < 1 ? (mainHandDelayHasteAdjustedInSeconds / offHandDelayHasteAdjustedInSeconds) : 1; 	// Off hand cannot be faster than mainhand. Clamp to 1 if off hand is faster.
}

Lmao I guess so.

[DeathsSilkyMist]

Originally Posted by bcbrown [You must be logged in to view images. Log in or Register.]

I'm saying the wiki version seems to correctly treat offhand delay. Did you really mess it up in the later version?

function computeWeaponDelayWithHaste(attackerStatStruct, bUseOffhand, bLogHasteValue)
{
	const mn_WeaponDelayDenominator = 100;

	var attackerWeaponDelay = attackerStatStruct.mainHandWeaponDelay;
	if(bUseOffhand)
	{
		attackerWeaponDelay = attackerStatStruct.offHandWeaponDelay;
	}
	...
}

function RunCombatSimulation(...)
{
	...
	const mainHandDelayHasteAdjustedInSeconds = (computeWeaponDelayWithHaste(attackerStatStruct, false, false) / 10);
	const offHandDelayHasteAdjustedInSeconds = (computeWeaponDelayWithHaste(attackerStatStruct, true, false) / 10);
	...
	const mainHandOffHandDelayRatio = (mainHandDelayHasteAdjustedInSeconds / offHandDelayHasteAdjustedInSeconds) < 1 ? (mainHandDelayHasteAdjustedInSeconds / offHandDelayHasteAdjustedInSeconds) : 1; 	// Off hand cannot be faster than mainhand. Clamp to 1 if off hand is faster.
}

Lmao I guess so.

You read the code wrong, and you are still referencing wiki results after I told you it wasn't finished. As I've said before, you need to actually read. I'd be curious to know if you can figure out what the issues were.

[bcbrown]

That's the new code, I didn't look at the old code. I just noticed that the DPS prediction (on the wiki) went down when you increased the offhand delay and figured it was correctly handling offhand delay.

Are you saying both versions incorrectly handle offhand delay? That's even funnier.

[DeathsSilkyMist]

Originally Posted by bcbrown [You must be logged in to view images. Log in or Register.]

That's the new code, I didn't look at the old code. I just noticed that the DPS prediction (on the wiki) went down when you increased the offhand delay and figured it was correctly handling offhand delay.

Are you saying both versions incorrectly handle offhand delay? That's even funnier.

You still haven't shown where the offhand is timer in either codebase. So you don't know how either work.

Keep the gloating posts coming, they just prove my point about you further.

[bcbrown]

I don't care about your DPS calculator, whether it's right or wrong. Just not useful for me. If you find it useful, great!

I'm just amused you wrote a whole-ass DPS simulator without knowing that offhand weapons aren't triggered off mainhand swings.

[DeathsSilkyMist]

Originally Posted by bcbrown [You must be logged in to view images. Log in or Register.]

I don't care about your DPS calculator, whether it's right or wrong. Just not useful for me. If you find it useful, great!

I'm just amused you wrote a whole-ass DPS simulator without knowing that offhand weapons aren't triggered off mainhand swings.

This is precisely why you are a poor contributor to this forum.

Instead of being interested in what other people have done/contributed, you mainly care about finding mistakes and attacking people for them. You focus more on that than actually trying to help people or understand the game.

At least you exposed yourself for people to see. Thanks for that.

Thank you to Zuranthium and Goregasmic for pointing out the independent offhand timer!

I'll fix the calculator and update it soon, it's only a few lines of code that need changing. This is why I shared my calculator, so I could get input from other players to see if I missed anything.