The Last Hoorah...

[loramin]

Originally Posted by Secrets [You must be logged in to view images. Log in or Register.]

It is a few numbers in an array though.

https://github.com/EQEmu/Server/blob...tack.cpp#L4537

Also, the reason why the patches get delayed is purely political reasons imposed by Daybreak, as far as I know?

But again, if that was true, why didn't they just release it with everything else? It doesn't make any sense that Daybreak would care whether P99 releases the entire "Chardok 2.0" patch at once or not. I mean, can you really see someone at Daybreak telling Rogean "Ok, you're allowed to release Chardok 2.0, but don't you dare release those melee number changes as part of it?"

And as for whether it literally requires only "a few numbers in the array" in the code ... c'mon Secrets, you're a dev. You know there's more than just the code: there's updating unit tests, there's the research behind those numbers, there's making sure that the array is the only place that needs changing, there's manual testing, there's ...

I mean, you know the P99 dev team a lot better than I do [You must be logged in to view images. Log in or Register.] But still, even with my limited knowledge of them, it just would make no sense for them to hold off "changing a few numbers in an array", specifically splitting up a Verant patch into multiple P99 patches (something they rarely do), for no reason (or for Daybreak's sake).

It seems far more likely that there was more work to do, so they decided not to release it until that work was done.

[Secrets]

Originally Posted by loramin [You must be logged in to view images. Log in or Register.]

there's updating unit tests,

I stopped reading there. I think the last time I wrote a unit test, even including industry experience, was like 2007.

We don't really use those here. It's numbers in an array and it won't be that big of a change (it wasn't on live at the time, either)

[Dolalin]

Originally Posted by Secrets [You must be logged in to view images. Log in or Register.]

I stopped reading there. I think the last time I wrote a unit test, even including industry experience, was like 2007.

Uh, what? Even our frontend javascript guys are writing unit tests. That's crazy.

[Psyborg]

Originally Posted by Dolalin [You must be logged in to view images. Log in or Register.]

Uh, what? Even our frontend javascript guys are writing unit tests. That's crazy.

Yeah I have to object to this notion that unit tests are some sort of outdated process. I have never worked on a mission critical project where they were not used somewhere.

[Secrets]

Originally Posted by Psyborg [You must be logged in to view images. Log in or Register.]

Yeah I have to object to this notion that unit tests are some sort of outdated process. I have never worked on a mission critical project where they were not used somewhere.

Must not have worked in games at all then... maybe in business programming they're used still.

[Pringles]

Originally Posted by Secrets [You must be logged in to view images. Log in or Register.]

Must not have worked in games at all then... maybe in business programming they're used still.

Only a mere 99% of the industry!