Texture patcher - Fix transparent visors/black feet etc

[Ropethunder]

Originally Posted by paulgiamatti [You must be logged in to view images. Log in or Register.]

Wrote a process that deletes your current .old backups when you run patch_s3d_textures.bat ... Basically, if you ran patch_s3d_textures.bat while .old backup files already existed, it would revert to and then apply the transpfix.exe changes to those instead of applying the changes to your current S3Ds.

This is how it's supposed to work. If you run the .bat file multiple times it first reverts all of the previous changes so that it doesn't patch the same texture twice. The tool doesn't know and can't know whether a texture has been patched previously and performing this operation on a texture more than once will have unexpected results.

Imagine I have a file with the following numbers:

00010001000

Now lets say that the texture patcher swaps the first '1' encountered to '2' and you get this:

00020001000

If you run the patcher on the same file without replacing it with the original then all of the number '1' get set to '2' instead of just the first one:

00020002000

To clarify: the patcher will definitely and absolutely do weird things to textures if you run it multiple times without reverting to the original first. That's what the .old is for.

[paulgiamatti]

That would certainly explain some of the texture oddities we've been experiencing - I removed the command to purge the .olds and reuploaded. Same link. Thanks for the clarification!

[paulgiamatti]

Originally Posted by Ropethunder [You must be logged in to view images. Log in or Register.]

To clarify: the patcher will definitely and absolutely do weird things to textures if you run it multiple times without reverting to the original first.

Although, now you've got me wondering - what kind of effect would it have? Would it only mess with a texture's transparency, or could it potentially do other things as well?

[Ropethunder]

Originally Posted by paulgiamatti [You must be logged in to view images. Log in or Register.]

Although, now you've got me wondering - what kind of effect would it have? Would it only mess with a texture's transparency, or could it potentially do other things as well?

Nothing good. The result will depend entirely on which options are chosen when the tool is run.

See here for some details on the implementation:
https://www.project1999.com/forums/s...d.php?p=259375

[paulgiamatti]

Originally Posted by Ropethunder [You must be logged in to view images. Log in or Register.]

The tool doesn't know and can't know whether a texture has been patched previously and performing this operation on a texture more than once will have unexpected results.

Logically this makes perfect sense, but it appears to be recognizing when something has already been patched and then skips the patching process for those S3Ds:

[You must be logged in to view images. Log in or Register.]

The left window is the output from running patch_s3d_textures.bat after reverting to stock S3Ds - it sees that stuff hasn't been patched, and lists each file it's writing to. The right window is output from running it a second time after I deleted all of my .old backups.