What's with the rain on this server?

[seped]

Originally Posted by LiQuid [You must be logged in to view images. Log in or Register.]

And when it does rain it seems to rain way too long... If I'm camping something outdoors and it starts to rain I prepare to hate my life for the next few hours at least.

Stupid rain.

Not too surprising, here's your culprit

if(zone->zone_weather != zone->weather_type)
weatherTime = (MakeRandomInt(1800, 7200) + 30) * 2000;
else
weatherTime = (MakeRandomInt(900, 2700) + 30) * 1000;

Assuming milliseconds, you're looking at a minimal of an hour of rain as soon as it starts, up to 4 hours and change before it even has a chance to stop raining, and then it only has a 20% chance to stop raining at each check. Unless I'm missing something (which with a scary code base like this is likely) it's going to be an average of 2.5 hours per check while raining, then 30 minutes per check while not raining. It really seems like this if statement should be reversed to give the desired behavior, unless counter-intuitively zone->weather_type is not the default weather state of a zone (dry/raining). Huge caveats as I've never looked at the code base before just now.