Quote:
Originally Posted by bcbrown
[You must be logged in to view images. Log in or Register.]
|
Quote:
Originally Posted by loramin
[You must be logged in to view images. Log in or Register.]
Wiki timeouts have been given out to the relevant parties, and the page has been reverted to what I think is (I'm not going to actually read every one of those edits) the most neutral and community-beneficial version.
Going forward, please, keep RnF in RnF (not in the wiki), and only edit the wiki with the goal of benefiting the entire community. I don't want to have to lock the page [You must be logged in to view images. Log in or Register.]
P.S. It's good to have a laptop again! Even if the screen is still broken, after well over a month in the shop (fuck you ubreakifix!)
|
The pseudo-code variation you created has some errors. That is another reason why I backed it out. If you are going to re-transcribe it, please actually take the time to do it right.
In the Archery section:
Quote:
if Archery and mob is rooted or moving:
DamageDone = DamageDone / 2
|
This is incorrect, as the stationary conditional is Ranger only. This if statement as-is would run for every class.
It should read something like:
Quote:
If Archery:
DamageDoneModifier = 2
If Archery and Ranger and Mob is not Rooted and Mob is not Moving:
DamageDoneModifier = 1
DamageDone = DamageDone / DamageDoneModifier
|
This is missing a > at the end of the random value, and you missed the maxExtra clamp completely:
Quote:
|
ExtraPercent = 100 + (BaseBonus * <random value between 0.0 and 1.0)
|
It should be:
Quote:
ExtraPercent = 100 + (BaseBonus * <random value between 0.0 and 1.0>)
If ExtraPercent > maxExtra:
ExtraPercent = maxExtra
|
Please make those changes. I will review it again when you are done.