Yeah I think that is a good overview of the code!
My SK is 58, so he would be using this table entry: { 265 Max Extra, 28 Chance, 70 Minusfactor.}
I had slightly off numbers for my STR and Offense. He has 226 STR and 224 Offense, and +48 ATK with 2 AoB items, Firefist, and Grim Aura. He is using
https://wiki.project1999.com/Eye_of_the_Rigtorgn , which has 25 Damage on it, and is a 1h weapon.
Based on the EQEMU formula my max damage would be as follows:
1. Calculate the "Offense" variable, which isn't simply the offense skill: 224 Offense Skill + ((2 * 226 Strength - 150) / 3) + 48 ATK = 372.6666666666667.
2. Apply the damage table:
2a. 372.6666666666667 "Offense" - 70 Minusfactor = 302.6666666666667
2b. (302.6666666666667 / 2) + 100 = 251.3333333333334 "extra percent damage"
2c. ((25 Weapon Damage * 2) * 251.3333333333334) / 100 = 125.6666666666667 damage. Add the 11 main hand weapon bonus for a total of 136 max damage. I have only hit for 132 so far, but maybe I could go a bit higher, or the calculation is a tad different on P99.
The one assumption I am making is they are multiplying weapon damage by 2 on step 2c. I can't actually find that anywhere in the code, but it is common knowledge that weapon damage is multiplied by 2.
Either that is P99 specific, or somewhere in the code I can't find. The function that pulls weapon damage on EQEMU seems to just pull the raw damage value. Maybe the damage gets doubled somewhere else a bit further along the function chain.