The underlying issue is the current method of allowing an instant click item to not use reagents.. is to make a new spell id that doesn't use components. Then, changing the clickeffect of the item to the non-component spell.
This is why some of the items function as intended, and some do not. Long long ago I made those changes for the mage ring, waterstone, and mystic cloak.
With that said, spell ids come at a premium. I believe the cap for spellids in spells_new for Titanium is 9999. I'm not totally sure what would happen if we exceeded it, but it would likely involve cthulu. I do not believe we should create a new spellid for each instance of this.
I will confer with the other developers and see if they have another idea.
The following is a list of items with instant clicks where the click effect is a spell which normally requires components. Please review this list and see which, if any, do not belong.
Code:
select i.id, i.name, i.casttime, i.casttime_, i.clickeffect, sn.name, sn.components1, i2.name
from items i
join spells_new sn on (sn.id = i.clickeffect)
join items i2 on (i2.id = sn.components1)
where i.casttime <= '0' and i.clickeffect > '0' and sn.components1 >= '0'
id name casttime casttime_ clickeffect name1 components1 name2
1400 Moss Mask 0 0 86 Enduring Breath 13076 Fish Scales
1593 Sacred Runed Jasper 0 0 261 Levitate 13068 Bat Wing
1846 Staff of Beta Corpse Summon 0 0 3 Summon Corpse 17355 Jade Inlaid Coffin
2703 Griffon Wing Spauldors 0 0 261 Levitate 13068 Bat Wing
2709 Rotted Griffon-Hide Wrist Guard 0 0 261 Levitate 13068 Bat Wing
3393 Shell Trimmed Bracer 0 0 86 Enduring Breath 13076 Fish Scales
3846 Black Feathered Circlet 0 0 261 Levitate 13068 Bat Wing
5126 Hero's Khukri 0 0 86 Enduring Breath 13076 Fish Scales
5128 Lord of Pain's Khukri 0 0 86 Enduring Breath 13076 Fish Scales
5377 Deep Six Cutlass 0 0 86 Enduring Breath 13076 Fish Scales
5738 Crypt Master`s Conjuring Stone 0 0 1773 Conjure Corpse 9962 Tiny Jade Inlaid Coffin
7027 Kerran Fishing Spear 0 0 86 Enduring Breath 13076 Fish Scales
7319 Riptide Spear 0 0 86 Enduring Breath 13076 Fish Scales
8443 Bag of Bone Dust 0 0 86 Enduring Breath 13076 Fish Scales
10377 Wand of Shadow 0 0 494 Invoke Shadow 13073 Bone Chips
11099 Akkirus Aego Buffer 0 0 1447 Aegolism 10028 Peridot
11151 Lightning Earring 0 0 635 Greater Conjuration: Air 10015 Malachite
11152 Fiery Earring 0 0 634 Greater Conjuration: Fire 10015 Malachite
11605 White Dragon Tooth 0 0 443 Invoke Death 13073 Bone Chips
11627 Red Dragon Tooth 0 0 443 Invoke Death 13073 Bone Chips
11632 Bladestopper 0 0 484 Rune IV 10028 Peridot
11686 Solidate Mithril Ring 0 0 393 Steelskin 10020 Jasper
11688 Rod of Warding Winds 0 0 483 Rune III 10020 Jasper
13251 Giant Fire Beetle Eye 0 0 667 Enchant Silver 16500 Silver Bar
13745 Enlarged Fire Beetle Eye 0 0 667 Enchant Silver 16500 Silver Bar
14177 5 Dose Potion of Vox's Vitality 0 0 86 Enduring Breath 13076 Fish Scales
14302 Vial of Egg Whites 0 0 86 Enduring Breath 13076 Fish Scales
14304 Brazier of Elemental Summoning 0 0 403 Elemental: Fire 10016 Lapis Lazuli
14396 10 Dose Potion of Vox's Vitality 0 0 86 Enduring Breath 13076 Fish Scales
14517 Fish Gill Extract 0 0 86 Enduring Breath 13076 Fish Scales
14556 Amulet of Planar Transference 0 0 674 Alter Plane: Sky 10094 Cloudy Stone of Veeshan
15982 Mystic Brooch 0 0 393 Steelskin 10020 Jasper
16461 Potion of Vox's Vitality 0 0 86 Enduring Breath 13076 Fish Scales
16873 Aqualung 0 0 478 Breath of the Dead 13076 Fish Scales
21603 Deeppocket Hollow Staff 0 0 1777 Conceal Rapier 21602 Deeppocket Rapier
21607 Imbued Deeppocket Traveling Staff 0 0 1782 Unconceal Rapier 21607 Imbued Deeppocket Traveling Staff
24737 Drums of the Beast 0 0 86 Enduring Breath 13076 Fish Scales
27710 Amulet of the Void 0 0 674 Alter Plane: Sky 10094 Cloudy Stone of Veeshan
27711 Rod of the Protecting Winds 0 0 483 Rune III 10020 Jasper
27712 Bloody Griffon-Hide Wrist Guard 0 0 261 Levitate 13068 Bat Wing
29050 Dragon Tooth Choker 0 0 236 Shieldskin 10026 Cat's Eye Agate
59715 Orb of Transmutation 0 0 4350 Transmute Hunter's Dagger 59740 Purified Crystal