Damage Shield Buff Message

[Daldaen]

The game incorrectly gives the line of text as though you are buffing an NPC with your DS spell if the NPC is killed from a DS hit. Example:

[Tue Jan 28 20:08:24 2014] Froglok jin shaman hits Meatdawg for 79 points of damage.
[Tue Jan 28 20:08:24 2014] Froglok jin shaman is surrounded by a thorny barrier of blades.
[Tue Jan 28 20:08:24 2014] froglok jin shaman has been slain by Meatdawg!
[Tue Jan 28 20:08:24 2014] You gain party experience!!

[Tue Jan 28 20:10:22 2014] Froglok dar knight was pierced by thorns.
[Tue Jan 28 20:10:22 2014] Froglok dar knight hits Meatdawg for 32 points of damage.
[Tue Jan 28 20:10:22 2014] Froglok dar knight is surrounded by a thorny barrier of blades.
[Tue Jan 28 20:10:22 2014] froglok dar knight has been slain by Meatdawg!
[Tue Jan 28 20:10:22 2014] You gain party experience!!

The bolded is the text that you should get if you cast the spell on someone. It is bugged and using that text when an NPC is killed by that DS.

[Haynar]

cool. Have to look into this one.

[Yinikren]

Can confirm, been around a while now.

[evilkorn]

Is this bugged for DoT's as well?

[Thu Jan 30 11:48:55 2014] a seafury cyclops was hit by non-melee for 143 points of damage.
[Thu Jan 30 11:48:55 2014] A seafury cyclops is consumed by the raging spirits of the land.
[Thu Jan 30 11:48:55 2014] You have slain a seafury cyclops!
[Thu Jan 30 11:48:55 2014] You gain experience!!

[Haynar]

How should it look?

[Daldaen]

Is this bugged for DoT's as well?

[Thu Jan 30 11:48:55 2014] a seafury cyclops was hit by non-melee for 143 points of damage.
[Thu Jan 30 11:48:55 2014] You have slain a seafury cyclops!
[Thu Jan 30 11:48:55 2014] You gain experience!!
Like that.

Or remove my bolder lines from above.

Basically the 'lore' text which the game uses to designate a successful landing of the spell (allakhazam calls this "Cast on Others") is incorrectly being interjected when a mob is slain by a non-direct spell.

So if you cast a DoT, it should look like this:

'Lore text' of a spell that didn't get resisted
10 tics of DoT DMG
11th tic is a kill shot
Mob has been slain
You gain experience

What's happening on P99 is this:

'Lore text' of a spell that didn't get resisted
10 tics of DoT DMG
11th tic is a kill shot
'Lore text' of a spell that didn't get resisted
Mob has been slain
You gain experience

It shouldn't give that message a second time unless you recast the spell.

Same deal with DSes

'Lore text' of buffing a friendly
Fight stuff
Mob swings and hits player
Damage shield does damage
Mob has been slain
You gain experience

What's happening on P99:

'Lore text' of buffing a friendly
Fight stuff
Mob swings and hits player
Damage shield does damage
'Lore text' of buffing MOB
Mob has been slain
You gain experience

If these were direct damage spells/nukes, this would look correct.

Begin casting spell
'Lore text' of fire encircling a mob
Mob takes 700 DMG
Mob has been slain
You Gain experience

[Haynar]

I think its because the spell id is sent in the kill packet. Will play with it.

[Haynar]

Sure, I think this one should be easy ...

NOT!!!!

Getting the messages in the right order is such a pain. No wonder this has always been messed up.

H

[Calabee]

uh that's not the mssg i get on my druid

ill turn on logs and post

actually nm! guess it is. self ds is the one that's different

[Haynar]

This should be better now. I couldnt get it perfect due to the way some of stuff is ordered in code without lots of changes.

Haynar